Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e test for juicefs #2505

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Jan 9, 2023

Signed-off-by: zwwhdls [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #2505 (b71a535) into master (2967f96) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2505      +/-   ##
==========================================
+ Coverage   67.42%   67.48%   +0.05%     
==========================================
  Files         367      367              
  Lines       21225    21237      +12     
==========================================
+ Hits        14312    14331      +19     
+ Misses       5231     5221      -10     
- Partials     1682     1685       +3     
Impacted Files Coverage Δ
pkg/ctrl/watch/pod.go 71.21% <100.00%> (ø)
pkg/ddc/juicefs/shutdown.go 56.14% <100.00%> (ø)
pkg/utils/kubeclient/volume.go 71.94% <0.00%> (-1.91%) ⬇️
pkg/utils/dataset/volume/delete.go 56.71% <0.00%> (+27.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zwwhdls
Copy link
Member Author

zwwhdls commented Jan 9, 2023

/test fluid-e2e



def main():
config.load_kube_config()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change it to config.load_incluster_config() and retry fluid-e2e test

Signed-off-by: zwwhdls <[email protected]>
@zwwhdls
Copy link
Member Author

zwwhdls commented Jan 10, 2023

/test fluid-e2e

@TrafalgarZZZ
Copy link
Member

/retest

1 similar comment
@TrafalgarZZZ
Copy link
Member

/retest

@zwwhdls
Copy link
Member Author

zwwhdls commented Jan 10, 2023

/retest

@zwwhdls
Copy link
Member Author

zwwhdls commented Jan 10, 2023

/test fluid-e2e

@zwwhdls
Copy link
Member Author

zwwhdls commented Jan 11, 2023

/test fluid-e2e

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ
Copy link
Member

/retest

@TrafalgarZZZ
Copy link
Member

/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Jan 11, 2023
@fluid-e2e-bot fluid-e2e-bot bot merged commit 5cf584d into fluid-cloudnative:master Jan 11, 2023
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 14, 2023
* add e2e test for juicefs

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix juicefs e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix job volume name in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>

Signed-off-by: zwwhdls <[email protected]>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* add e2e test for juicefs

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix juicefs e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix job volume name in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>

Signed-off-by: zwwhdls <[email protected]>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* add e2e test for juicefs

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix juicefs e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix job volume name in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>

Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: cheyang <[email protected]>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* add e2e test for juicefs

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix juicefs e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix job volume name in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>

Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: cheyang <[email protected]>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* add e2e test for juicefs

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix juicefs e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix job volume name in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>

Signed-off-by: zwwhdls <[email protected]>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* add e2e test for juicefs

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix eci label in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix juicefs e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix job volume name in e2e test

Signed-off-by: zwwhdls <[email protected]>

* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>

Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: cheyang <[email protected]>
cheyang added a commit that referenced this pull request Feb 18, 2023
* add e2e test for juicefs



* fix eci label in e2e test



* fix eci label in e2e test



* fix juicefs e2e test



* fix job volume name in e2e test



* fix handle multi sidecar in appcontroller

Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: cheyang <[email protected]>
Co-authored-by: Weiwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants